Use Console.IsOutputRedirected instead of P/Invoke for redirect detection#2001
Open
tyrielv wants to merge 1 commit into
Open
Use Console.IsOutputRedirected instead of P/Invoke for redirect detection#2001tyrielv wants to merge 1 commit into
tyrielv wants to merge 1 commit into
Conversation
…tion The previous IsConsoleOutputRedirectedToFile() used Win32 GetFileType to check if stdout was redirected to a disk file. This missed the pipe case (GetFileType returns Pipe, not Disk), so the console spinner would still run when stdout was captured via Process.Start with RedirectStandardOutput (e.g. in functional tests and CI), polluting captured output with \r and spinner characters. Replace with .NET's Console.IsOutputRedirected which returns true for any non-console handle (files, pipes, NUL). Remove the now-unused P/Invoke declarations (GetStdHandle, GetFileType) and the platform abstraction (IsConsoleOutputRedirectedToFile) from GVFSPlatform, WindowsPlatform, GVFSHooksPlatform, and MockPlatform. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous
IsConsoleOutputRedirectedToFile()used Win32GetFileTypeto check if stdout was redirected to a disk file. This missed the pipe case (GetFileTypereturnsPipe, notDisk), so the console spinner would still run when stdout was captured viaProcess.StartwithRedirectStandardOutput(e.g. in functional tests and CI), polluting captured output with\rand spinner characters.Replace with .NET's
Console.IsOutputRedirectedwhich returns true for any non-console handle (files, pipes, NUL). Remove the now-unused P/Invoke declarations (GetStdHandle,GetFileType) and the platform abstraction (IsConsoleOutputRedirectedToFile) fromGVFSPlatform,WindowsPlatform,GVFSHooksPlatform, andMockPlatform.